Repository navigation
Show an enable hint when Workflows settings cannot find the plugin - #1386
Merged
Merged
Conversation
Settings → Workflows showed the host string "Unknown FlyBot endpoint workflow/state" when @flybot/workflow was not registered. Map bot/not-found and that endpoint phrase to the install-or-enable hint, in English and Chinese, and keep Retry. A present endpoint is unchanged. Fixes #1381 Co-authored-by: Danyang Chen <birfychen@gmail.com>
github-actions
Bot
added
the
risk:T1
Collaborator
Author
|
Verdict: PASS at 205be1b Ran / reviewed:
Ready for merge queue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written-by: Dev
Owner: Dev
Reviewer: Reviewer
Fixes #1381
What changed
Settings → Workflows showed
Unknown FlyBot endpoint workflow/stateplus Retry when@flybot/workflowwas not registered. Abot/not-foundresult, or thatworkflow/…endpoint phrase, now says the Workflow plugin is not installed or not enabled, and that a default install includes@flybot/workflow. The sentence is English or Chinese with the interface language. Retry stays. A present endpoint still lists the factory presets and saved workflows and opens the flowchart.Verification at the tip
Tip SHA:
205be1bea0603bfeac3422029cd8e7b9f71489a4Ran (defect test, red on base
bcb039efc8c25b18ad0d2cd100bad34342ca3f9abefore the fix):node --import ./test/harness-resolve.mjs --test test/workflows-page.test.jsincore/— 6 pass, 1 fail. Actual error wasUnknown FlyBot endpoint workflow/state.Ran at this tree, then committed as the tip above:
npm run lintincore/(oxlint warnings unchanged;arch-docs: OK (10 changed file(s))after the commit)node scripts/build-client.mjs --checknode scripts/ds-bot-patches.mjs checkTZ=UTC npm testincore/— 1797 pass, 0 failnode scripts/lint-plugins.mjsnode --test .github/scripts/*.test.mjs— 543 passnode .github/scripts/changelog.mjs checknode .github/scripts/check-mojibake.mjs --checkNot run: smoke bench (no
index.jsorsrc/host/change), pack check, actionlint, interop, live-e2e, typecheck.Checkpoint
{ "pr": 1386, "claim": "Dev", "issue": 1381, "summary": "Settings → Workflows showed the raw host error when @flybot/workflow was not registered. A missing workflow/state call (bot/not-found, or Unknown FlyBot endpoint workflow/…) now says the Workflow plugin is not installed or not enabled, and that a default install includes @flybot/workflow. The same words are used in English and Chinese. Retry stays on that error. A registered plugin still lists factory presets and saved workflows and opens the flowchart.", "files": ["core/src/client/workflows.js", "core/src/client/i18n.js", "core/test/workflows-page.test.js", "core/client.js", "docs/subsystems/core-client.md", "changelog.d/1381-workflow-settings-hint.fixed.md"], "checks": { "ran": "TZ=UTC npm test in core (1797 pass); npm run lint; ds-bot-patches check; plugin tests 0 fail", "result": "green", "at": "205be1bea0603bfeac3422029cd8e7b9f71489a4" }, "next": "none — ready for review" }